fix: persist model capabilities refresh app #5918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to d2ae006 in 1 minute and 9 seconds. Click for details.
- Reviewed
29lines of code in2files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/hooks/useModelProvider.ts:77
- Draft comment:
Good use of assigning 'existingModel' to preserve persisted settings. Consider adding a brief comment explaining that this ensures any user changes to settings and capabilities are retained. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. web-app/src/hooks/useModelProvider.ts:82
- Draft comment:
Persisting 'capabilities' along with 'settings' addresses issue #5900. Ensure that new tool support defaults (e.g., for Lucy) are initialized appropriately elsewhere. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. web-app/src/types/models.ts:22
- Draft comment:
Added Lucy to DefaultToolUseSupportedModels. Confirm that Lucy’s default capabilities (e.g., tool support enabled) are set during model initialization. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_IMWNxbtVundAuAYG
You can customize 
Contributor
qnixsynapse
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request introduces updates to the
ModelProviderhook and theModelCapabilitiesenum to enhance model handling and support for additional capabilities. The most important changes include improving the logic for updating model settings and capabilities, and adding a new model to the list of supported tools.Enhancements to model handling:
web-app/src/hooks/useModelProvider.ts: Improved the logic for updating models by introducingexistingModelto streamline access to model properties (settingsandcapabilities). This ensures that existing model attributes are preserved during updates.Support for additional tools:
web-app/src/types/models.ts: Added a new model,Lucy, to theDefaultToolUseSupportedModelsenum, expanding the list of supported tools.Fixes Issues
Self Checklist
Important
Enhances model handling in
useModelProvider.tsby preserving attributes during updates and addsLucyto supported tools inmodels.ts.useModelProvider.ts, improved model update logic by introducingexistingModelto preservesettingsandcapabilitiesduring updates.models.ts, addedLucytoDefaultToolUseSupportedModelsenum, expanding supported tools list.This description was created by
for d2ae006. You can customize this summary. It will automatically update as commits are pushed.